Use default values provided by DataStore params when creating new datastores

Description

Use default values provided by DataStoreFactory params when creating new datastores. It should be usefull to have default parameter values for those datastores who uses some parameter as hints, such as default port number, default number of min and max connections, etc

Environment

None

Activity

Show:
codehaus
April 10, 2015, 4:36 PM

CodeHaus Comment From: jgarnett - Time: Sun, 14 Mar 2004 16:32:23 -0600
---------------------
<p>EXTERNAL MESSAGE:

SUBJECT: Re: <span class="error">&#91;Geoserver-devel&#93;</span> <span class="error">&#91;jira&#93;</span> Created: (<a href="https://jira.codehaus.org/browse/GEOS-122" title="Use default values provided by DataStore params when creating new datastores" class="issue-link" data-issue-key="GEOS-122"><del>GEOS-122</del></a>) Use default values provided by DataStore params when creating new datastores

Quoting jira@codehaus.org:</p>

<p>I think some of this has been provided by the GeoTools DataStoreFactory.Param

class. At least I think default values are mentioned.</p>

<p>Q: What should the default value appear as

(I assume we use the value when creating the default params when the DataStore

is 1st created) either:

a) show the value but don't record it - so we know to use the default in the future

b) leave the entry empty (and have the default provided at runtime)

c) only use the default value for intial param generation</p>

<p>Leaning towards option c) because it is the least amount of work <img class="emoticon" src="https://jira.codehaus.org/images/icons/emoticons/smile.gif" height="16" width="16" align="absmiddle" alt="" border="0"/></p>

codehaus
April 10, 2015, 4:36 PM

CodeHaus Comment From: groldan - Time: Sun, 14 Mar 2004 17:20:26 -0600
---------------------
<p>EXTERNAL MESSAGE:

SUBJECT: Re: <span class="error">&#91;jira&#93;</span> Commented: (<a href="https://jira.codehaus.org/browse/GEOS-122" title="Use default values provided by DataStore params when creating new datastores" class="issue-link" data-issue-key="GEOS-122"><del>GEOS-122</del></a>) Use default values provided by DataStore params when creating new datastores

Exactly, that the expected use of DataStoreFactory.Param after all.

The default value definitely should appear when creating a new datastore

config, since users generally will not know what they should be, as for the

case of default database port numbers or those parameters used as hints.</p>

<p>I don't remember right now, but think Param has no 'optional' flag, so I'm

inclined to show the default param value in it's textbox letting the user

change it. The point of actually writting it or not may be a bit confusing,

so I advocate for option C too.</p>

<p>----- Original Message -----

From: &lt;jira@codehaus.org&gt;

To: &lt;gabriel.roldan@telefonica.net&gt;

Sent: Sunday, March 14, 2004 10:32 PM

Subject: <span class="error">&#91;jira&#93;</span> Commented: (<a href="https://jira.codehaus.org/browse/GEOS-122" title="Use default values provided by DataStore params when creating new datastores" class="issue-link" data-issue-key="GEOS-122"><del>GEOS-122</del></a>) Use default values provided by

DataStore params when creating new datastores</p>

<p>The following comment has been added to this issue:</p>

<p> Author: Jody Garnett

Created: Sun, 14 Mar 2004 4:32 PM

Body:

EXTERNAL MESSAGE:

SUBJECT: Re: <span class="error">&#91;Geoserver-devel&#93;</span> <span class="error">&#91;jira&#93;</span> Created: (<a href="https://jira.codehaus.org/browse/GEOS-122" title="Use default values provided by DataStore params when creating new datastores" class="issue-link" data-issue-key="GEOS-122"><del>GEOS-122</del></a>) Use default values

provided by DataStore params when creating new datastores

Quoting jira@codehaus.org:</p>

<p>I think some of this has been provided by the GeoTools

DataStoreFactory.Param

class. At least I think default values are mentioned.</p>

<p>Q: What should the default value appear as

(I assume we use the value when creating the default params when the

DataStore

is 1st created) either:

a) show the value but don't record it - so we know to use the default in the

future

b) leave the entry empty (and have the default provided at runtime)

c) only use the default value for intial param generation</p>

<p>Leaning towards option c) because it is the least amount of work <img class="emoticon" src="https://jira.codehaus.org/images/icons/emoticons/smile.gif" height="16" width="16" align="absmiddle" alt="" border="0"/></p>

<p>---------------------------------------------------------------------

View this comment:</p>

<p><a href="http://jira.codehaus.org/secure/ViewIssue.jspa?key=GEOS-122&amp;page=comments#ac" class="external-link" rel="nofollow">http://jira.codehaus.org/secure/ViewIssue.jspa?key=GEOS-122&amp;page=comments#ac</a>

tion_17551</p>

<p>---------------------------------------------------------------------

View the issue:

<a href="http://jira.codehaus.org/secure/ViewIssue.jspa?key=GEOS-122" class="external-link" rel="nofollow">http://jira.codehaus.org/secure/ViewIssue.jspa?key=GEOS-122</a></p>

<p>Here is an overview of the issue:

---------------------------------------------------------------------

Key: <a href="https://jira.codehaus.org/browse/GEOS-122" title="Use default values provided by DataStore params when creating new datastores" class="issue-link" data-issue-key="GEOS-122"><del>GEOS-122</del></a>

Summary: Use default values provided by DataStore params when creating

new datastores

Type: Improvement</p>

<p> Status: Unassigned

Priority: Minor</p>

<p> Original Estimate: Unknown

Time Spent: Unknown

Remaining: Unknown</p>

<p> Project: GeoServer

Components:

Configuration

Versions:

1.2.1</p>

<p> Assignee:

Reporter: Gabriel Roldán</p>

<p> Created: Sun, 14 Mar 2004 12:06 PM

Updated: Sun, 14 Mar 2004 4:32 PM</p>

<p>Description:

Use default values provided by DataStoreFactory params when creating new

datastores. It should be usefull to have default parameter values for those

datastores who uses some parameter as hints, such as default port number,

default number of min and max connections, etc</p>

<p>---------------------------------------------------------------------

JIRA INFORMATION:

This message is automatically generated by JIRA.</p>

<p>If you think it was sent incorrectly contact one of the administrators:

<a href="http://jira.codehaus.org/secure/Administrators.jspa" class="external-link" rel="nofollow">http://jira.codehaus.org/secure/Administrators.jspa</a></p>

<p>If you want more information on JIRA, or have a bug to report see:

<a href="http://www.atlassian.com/software/jira" class="external-link" rel="nofollow">http://www.atlassian.com/software/jira</a></p>

codehaus
April 10, 2015, 4:36 PM

CodeHaus Comment From: cholmes - Time: Tue, 6 Apr 2004 10:00:39 -0500
---------------------
<p>I don't need this for 1.2.0, but might be nice to try to hit.</p>

codehaus
April 10, 2015, 4:36 PM

CodeHaus Comment From: cholmes - Time: Wed, 7 Apr 2004 01:12:20 -0500
---------------------
<p>I vote for c too. </p>

codehaus
April 10, 2015, 4:36 PM

CodeHaus Comment From: cholmes - Time: Wed, 21 Apr 2004 12:49:51 -0500
---------------------
<p>Thanks Jody!</p>

Fixed

Assignee

Unassigned

Reporter

codehaus

Triage

None

Fix versions

Affects versions

Components

Priority

Low