Uploaded image for project: 'GeoServer'
  1. GeoServer
  2. GEOS-7457

Bad System.out.println logging usage

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Low
    • Resolution: Fixed
    • Affects Version/s: 2.8.2
    • Fix Version/s: 2.9.1, 2.10-M0
    • Component/s: Global
    • Labels:
      None
    • Environment:

      Tomcat 8, debian jessie

      Description

      The xslt extension uses System.out.println() to print debugging info instead of properly using geoserver logging, which can uselessly fill out catalina.out.

      While i can understand system.out.println() being used in tests, it shouldn't appear in production code..
      https://github.com/geoserver/geoserver/blob/master/src/extension/xslt/src/main/java/org/geoserver/wfs/xslt/XSLTOutputFormat.java#L83 is trigerred quite often here, and https://github.com/geoserver/geoserver/blob/master/src/extension/xslt/src/main/java/org/geoserver/wfs/xslt/XSLTOutputFormat.java#L95 happens too.

      https://github.com/geoserver/geoserver/search?utf8=%E2%9C%93&q=%22System.out.println%22&type=Code

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              landry Landry Breuil
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: