GetMapKvpReader is not Thread-safe

Description

The OWS Dispatcher has a special case for handling HttpServletRequestAware KvpRequestReaders: https://github.com/geoserver/geoserver/blob/master/src/ows/src/main/java/org/geoserver/ows/Dispatcher.java#L1492

This adds the current HttpRequest to the KvpRequestReader bean. HttpServletRequestAware is only implemented by GetMapKvpRequestReader, which passes the HttpRequest on to GetMapRequest, where it is eventually used by OpenLayersMapOutputFormat to determine whether or not the browser properly supports OL3.

This logic should be removed from the KvpRequestReader code and instead moved to the Dispatcher ThreadLocal.

Environment

None

Status

Assignee

Unassigned

Reporter

Torben Barsballe

Triage

Fix versions

Affects versions

None

Priority

Medium
Configure