Control Flow blacklist/whitelist error messages

Description

When GeoServer is initializing the Control Flow extension, it will log an error message if the "ip.blacklist" and/or "ip.whitelist" properties are used in controlflow.properties. For example,
ERROR [org.geoserver.flow.config] Rules should be assigned just a queue size, instead ip.blacklist is associated to 127.0.0.1

The error message(s) are harmless since those properties are used by a different class than the one logging the errors and there does not appear to be any loss of functionality. The error messages were cause by this commit:
https://github.com/geoserver/geoserver/commit/9f8e54b1626076c45e0a6cf586d6177861f6d1da#diff-cc6dd3266eed1773f4cc07231f92c028L74

where it changed from:
if(!"ip.blacklist".equals(key) && !"ip.whitelist".equals(key)){
...do stuff
}else{
continue;
}

to:
if("ip.blacklist".equals(key) && "ip.whitelist".equals(key)) {
continue;
} else {
...do stuff
}

but it should be using or instead of and:
if("ip.blacklist".equals(key) || "ip.whitelist".equals(key)) {
continue;

Environment

None

Status

Assignee

Unassigned

Reporter

Steve Ikeoka

Triage

Fix versions

Affects versions

Components

Priority

Medium
Configure