Conversion from boolean true/false in geoserver to SQL Server bit 0/1, is broken

Description

Hi
Stumbled across this bug:

When working with a layer from a SQL server that contains a bit WFS-T updates fail when the update contains the boolean. I have tried sending both 0/1 and true/false.

WFS-T error

Caused by: com.microsoft.sqlserver.jdbc.SQLServerException: Invalid column name 'false'.
at com.microsoft.sqlserver.jdbc.SQLServerException.makeFromDatabaseError(SQLServerException.java:217)
at com.microsoft.sqlserver.jdbc.SQLServerStatement.getNextResult(SQLServerStatement.java:1655)
at com.microsoft.sqlserver.jdbc.SQLServerStatement.doExecuteStatement(SQLServerStatement.java:885)
at com.microsoft.sqlserver.jdbc.SQLServerStatement$StmtExecCmd.doExecute(SQLServerStatement.java:778)
at com.microsoft.sqlserver.jdbc.TDSCommand.execute(IOBuffer.java:7505)
at com.microsoft.sqlserver.jdbc.SQLServerConnection.executeCommand(SQLServerConnection.java:2445)
at com.microsoft.sqlserver.jdbc.SQLServerStatement.executeCommand(SQLServerStatement.java:191)
at com.microsoft.sqlserver.jdbc.SQLServerStatement.executeStatement(SQLServerStatement.java:166)
at com.microsoft.sqlserver.jdbc.SQLServerStatement.execute(SQLServerStatement.java:751)
at org.apache.commons.dbcp.DelegatingStatement.execute(DelegatingStatement.java:264)
at org.apache.commons.dbcp.DelegatingStatement.execute(DelegatingStatement.java:264)
at org.geotools.jdbc.JDBCDataStore.update(JDBCDataStore.java:2016)
... 121 more

It also fails to render if you make a filter in the SLD using the bit/boolean.

Environment

None

Status

Assignee

Unassigned

Reporter

Michael Weber

Triage

Fix versions

None

Affects versions

Components

Priority

Medium
Configure