Use of GeometryClipper for Perpendicular Offset

Description

This fixes a regression introduced with the use of a preserveTopology flag.

  • preserveTopology is set or the perpendicular offset styling of polygon data

  • preserveTopology selects between JTS clip (slow, willing to check invalid) and a fast geotools clip.

The logic was reversed sending all clipped features to the JTS routine introducing a performance regression.

Environment

None

Activity

Show:
David Blasby
December 16, 2015, 11:53 PM
Jody Garnett
December 17, 2015, 12:53 AM
Edited

Applied this to geotools master, and get a failure when testing geoserver locally:

class UTFGridIntegrationTest

Checking history this test was added in the last 40 days - so I am not sure if the failure represents a significant visual difference.

Update: The test was just brittle - fixed downstream.

Andrea Aime
December 17, 2015, 7:12 AM

Jody, normally the module maintainer merges the pulls on the modules he/she's after, not the random developer (and handles the consequences).

Andrea Aime
December 17, 2015, 7:16 AM

Btw, the perpendicular offset stuff is available only on trunk, thus, there is no need to backport the boolean flipping fix (and possibly the rest of the fix either, but that can be discussed).

Andrea Aime
February 15, 2017, 11:33 AM

Mass transitioning all resolved issues that have not been updated in the last month to closed state

Fixed

Assignee

Jody Garnett

Reporter

David Blasby

Triage

None

Components

Priority

Medium
Configure