This fixes a regression introduced with the use of a preserveTopology flag.
preserveTopology is set or the perpendicular offset styling of polygon data
preserveTopology selects between JTS clip (slow, willing to check invalid) and a fast geotools clip.
The logic was reversed sending all clipped features to the JTS routine introducing a performance regression.
Applied this to geotools master, and get a failure when testing geoserver locally:
Checking history this test was added in the last 40 days - so I am not sure if the failure represents a significant visual difference.
Update: The test was just brittle - fixed downstream.
Jody, normally the module maintainer merges the pulls on the modules he/she's after, not the random developer (and handles the consequences).
Btw, the perpendicular offset stuff is available only on trunk, thus, there is no need to backport the boolean flipping fix (and possibly the rest of the fix either, but that can be discussed).
Mass transitioning all resolved issues that have not been updated in the last month to closed state