PostgreSQL 9.6 breaks ASC_OR_DESC for index

Description

gt-jdbc-postgis tests fail against PostgreSQL 9.6 because most columns of the pg_am table have been removed, causing tests to fail with org.postgresql.util.PSQLException: ERROR: column am.amcanorder does not exist (see attached logs).

The fix is included in JDBC driver 9.4.1209 and later:
https://github.com/pgjdbc/pgjdbc/pull/560
https://jdbc.postgresql.org/documentation/changelog.html#version_9.4.1209

I propose that GeoTools master and 15.x be upgraded to 9.4.1211 (latest stable).

Environment

postgresql-9.6 9.6~rc1-1+b1 / postgresql-9.6-postgis-2.3 2.3.0~rc1+dfsg-1~exp2 on debian unstable (with postgis from experimental)

Activity

Show:
Ben Caradoc-Davies
September 26, 2016, 10:56 AM
Edited

Andrea,

as far as I know, this is just a bugfix upgrade 9.4-1201-jdbc41 -> 9.4.1211:
https://jdbc.postgresql.org/documentation/changelog.html

According to the docs, this driver supports PostgreSQL 7.2 or later. This is the recommended driver for most users:
https://jdbc.postgresql.org/download.html

The other change is moving from the driver built for JDK7 to one built for JDK8 / JDBC 4.2. The JDBC driver patch needed to fix gt-jdbc-postgis just adds a check to see if the database is 9.6 and then avoids using the removed column.

Kind regards,
Ben.

Ben Caradoc-Davies
September 26, 2016, 8:04 PM

Merged on master. The PR for 15.x held until after 15.2 is released.

Jody Garnett
October 9, 2016, 7:57 PM

Assuming if this is merged on master I can mark it as fixed by 16-RC

Ben Caradoc-Davies
October 9, 2016, 8:09 PM

Yes, Jody, that is correct, it should be in the changelog for 16-RC1. I held it open as I will backport to 15.x after 15.2, but really resolving it is the right thing to do.

Ben Caradoc-Davies
October 14, 2016, 9:08 PM
Edited

Merged on 15.x for inclusion in 15.3.

Fixed

Assignee

Ben Caradoc-Davies

Reporter

Ben Caradoc-Davies

Triage

None

Components

Fix versions

Affects versions

Priority

Medium
Configure