PostGISJsonOnlineTest.testEntryWithSpaces fails

Description

surefire report:

Environment

postgresql-10 10.1-1 amd64 / postgresql-10-postgis-2.4 2.4.2+dfsg-1 amd64 on debian/sid

Activity

Show:
Ben Caradoc-Davies
November 24, 2017, 12:04 AM

The failing assert uses a string literal that lacks the space between the \" and the } that is in the test data. See PostGISJsonTestSetup:53:
https://github.com/geotools/geotools/blob/master/modules/plugin/jdbc/jdbc-postgis/src/test/java/org/geotools/data/postgis/PostGISJsonTestSetup.java#L53

Ben Caradoc-Davies
November 24, 2017, 12:23 AM

Fixed on master in https://github.com/geotools/geotools/commit/befb6294f9432014aca61f6c33a0dddadbd97e60.

I rewrote the test to be simpler and stricter (assertEquals not assertTrue/assertFalse over String.contains).

I ran the test before committing.

Daniele Romagnoli
November 24, 2017, 8:45 AM

Thanks for the fix.
I have built it with -Ponline all the time then I did a manual indentation/format "cleanup" of the Setup class right before the PR but it looks like I have touched the content instead of the "external" indentation. Sorry for the issue.

Assignee

Ben Caradoc-Davies

Reporter

Ben Caradoc-Davies

Triage

None

Components

Fix versions

Affects versions

Priority

Medium
Configure