Fails to read MBTiles with JPG file format

Description

As initially reported on StackExchange:

https://gis.stackexchange.com/questions/270770/geoserver-cant-add-a-jpeg-mbtiles-file

The spec confirms "jpg" is a valid format here:

https://github.com/mapbox/mbtiles-spec/blob/master/1.3/spec.md

As suggested by Andrea and Ian, the fix is to add "JPG" to the enum here:

https://github.com/geotools/geotools/blob/master/modules/unsupported/mbtiles/src/main/java/org/geotools/mbtiles/MBTilesMetadata.java#L43

GitHub pull request incoming.

(Credit to my co-worker Murray McDonald for tracking this down and verifying the fix)

Environment

None

Activity

Show:
Leif Gruenwoldt
November 1, 2018, 11:30 AM

Yes, hopefully not too much longer. Are hoping it can make it into next stable release if we get the PR in soon

Leif Gruenwoldt
December 15, 2018, 3:57 AM
Edited

Sorry for the long delay. We have a new boss and he wanted to clarify with our client that they are still OK with us making contributions. The verdict is yes. So this time, pull request is coming very soon.

Leif Gruenwoldt
December 15, 2018, 4:08 AM

I've opened a pull request for this here:

https://github.com/geotools/geotools/pull/2210

Is it possible to have this merged in so that it makes it into the 19.4 release next week? We would leverage it right away.

Leif Gruenwoldt
December 21, 2018, 4:46 AM

I create a second PR for master, here:

https://github.com/geotools/geotools/pull/2211

This was merged. Thank you!

Close the issue?

Leif Gruenwoldt
January 10, 2019, 5:53 PM

Please feel free to close this issue, the PR was merged into master.

Fixed

Assignee

Unassigned

Reporter

Leif Gruenwoldt

Triage

None

Fix versions

Affects versions

Priority

Medium
Configure