JDBCDataStore-Bug with selectBoundsSQLPS

Description

Incomplete code changes for in JDBCDataStore _in method _selectBoundsSQLPS:

Please see this diff: https://github.com/geotools/geotools/commit/b11d0e97ef56f3afe1759a609#diff-3f08f2af86593cd27baeb630bf1b1869L3786

sql.append(" ").append(toSQL.encodeToString(filter));
was changed to (with some more code around):
sql.append(toSQL.encodeToString(filter));

I found this while doing a getfeature request in geoserver 2.14.0 with an oracle datastore:

Request:

The mentioned method creates a wrong sql statement - this is the exception:

Please focus on "...gisdb.xxxx_oracleWHERE..." - the missing space.

We also tried a similar request with a postgis datastore which works, because it uses method selectBoundsSQL

Environment

None

Status

Assignee

Unassigned

Reporter

Martin Zeller

Triage

Components

Fix versions

Affects versions

20.0
19.3

Priority

Medium
Configure