Improve "accepts" method on GRIB/NetCDF formats

Description

GribFormat and NetCDFFormat implement the AbstractGridFormat.accepts method by simply checking if the provided file has the expected file extension (as an instance, .grib, .nc, .ncml and so on).
It would be better to check for the magic number or something else which actually checks that the format can really handle that file.

Environment

None

Activity

Show:
Jody Garnett
November 20, 2019, 11:50 PM

you have marked this as fixed for 21.4 / 22.1 but not marked the issue as resolved.

Does this mean it is was your intension to target a release for this timeframe (if so you missed the deadline).

Daniele Romagnoli
November 21, 2019, 9:31 AM

Hi Jody,

I was just populating these fields with the incoming versions with the intention to update them (if needed) once the fix get handled and resolved. Actually, I didn’t start working on that yet (still in open status) so we may want to remove the “fix versions” if it is misleading.

Assignee

Daniele Romagnoli

Reporter

Daniele Romagnoli

Triage

None

Components

Affects versions

Priority

Medium
Configure