App-schema oracle tests fail on jenkins

I have a strong feeling that this 7 years old issue is not really fixed, but it is still outdated due to changes in build system.

Had further look on the Oracle failures on our local build.. The failures seem to come from Oracle not handling invalid coordinates in the query, not Geoserver issue. The query should return nothing instead of spitting out errors. Will try to patch or upgrade the db sometime.
The tests used to work with a different Oracle version.

All Failed Tests
org.geoserver.test.BBoxFilterTest.testQueryBboxLatLongEPSGCode
org.geoserver.test.BBoxFilterTest.testQueryBboxLongLat
org.geoserver.test.BBoxFilterTest.testQueryBboxLongLatURN

Caused by: java.sql.SQLException: ORA-29902: error in executing ODCIIndexStart() routine
ORA-13034: Invalid data in the SDO_ORDINATE_ARRAY in SDO_GEOMETRY object
ORA-06512: at "MDSYS.SDO_INDEX_METHOD_10I", line 333

-------- Forwarded Message --------
Subject: Re: FW: Build failed in Jenkins: geoserver-master-app-schema-online-test #1925
Date: Wed, 3 Aug 2016 16:33:39 +1200
From: Ben Caradoc-Davies
To: Rini Angreani

Rini,

I have shortened the table name for the tests to 20 characters:
master: https://github.com/geoserver/geoserver/commit/cb07d63c859371b12875dd940d480dece069a507
2.9.x: https://github.com/geoserver/geoserver/commit/42c2f2e5d9498082dc06ac77a8805183821afc7d
2.8.x: https://github.com/geoserver/geoserver/commit/ff9d416a4f0b32625908f6d6107034845f82c0c3

As for the other tests, the Google suggests that there might be a null in a geometry:
http://ora-13034.ora-code.com/

Kind regards,
Ben.

On 03/08/16 16:18, Rini Angreani wrote:
> OK good. By the way, the other failures I think are real failures that we didn't detect since 2 years ago.
> I can't/won't fix them right now.
> At least we have an Oracle test build now.
>
> Cheers
> Rini
>
> ----Original Message----
> From: Ben Caradoc-Davies
> Sent: Wednesday, 3 August 2016 12:16 PM
> To: Angreani, Rini (Mineral Resources, Kensington WA)
> Subject: Re: FW: Build failed in Jenkins: geoserver-master-app-schema-online-test #1925
>
> Ooh, right you are. The properties file for MultivaluedXlinkHrefClientPropertyTest is named, with my typical brevity, "MultivaluedXlinkHrefClientProperty.properties", resulting in an Oracle table name 'MULTIVALUEDXLINKHREFCLIENTPROPERTY', which is 34 characters.
>
> I will shorten this monstrosity right now!
>
> Kind regards,
> Ben.
>
> On 03/08/16 15:38, Rini Angreani wrote:
>> Ben,
>> Your last commit seems to break in Oracle. Something to do with Oracle
>> identifier 30 characters limit.
>> https://cgsrv8.arrc.csiro.au/jenkins/job/geoserver-master-app-schema-o
>> nline-test/1925/org.geoserver.extension$gs-app-schema-oracle-test/test
>> Report/
>>
>> I'm still looking into the other failures (not sure if it was caused by my fix last Friday). If it's not related to my changes, I don't think I'll fix it at this point.
>>
>> Cheers
>> Rini

We now have a semi-working Oracle build: https://cgsrv8.arrc.csiro.au/jenkins/job/geoserver-master-app-schema-online-test/lastBuild/testReport/
However, it is currently broken, but I think they are real failures, not setup/database failures.
Unfortunately, I can't look at this further at this point.

Thanks Ben. Someone removed my postgis database for jenkins, that's why it fails. The oracle is still down due to the same issue you were trying to fix before you left (something about the packages not being loaded in time).
We're using Oracle Database 11g Enterprise Edition Release 11.2.0.4.0 so hopefully when I get the issue fixed, we can have a running Oracle test again.