throw error while adding feature to FlatGeobuf featureStore

Description

java.lang.RuntimeException: Cannot handle datetime type java.util.Date at org.geotools.data.flatgeobuf.FeatureConversions.buildPropertiesVector(FeatureConversions.java:210) at org.geotools.data.flatgeobuf.FeatureConversions.createProperiesVector(FeatureConversions.java:124) at org.geotools.data.flatgeobuf.FeatureConversions.serialize(FeatureConversions.java:84) at org.geotools.data.flatgeobuf.FlatGeobufWriter.writeFeature(FlatGeobufWriter.java:40) at org.geotools.data.flatgeobuf.FlatGeobufFeatureWriter.write(FlatGeobufFeatureWriter.java:123) at org.geotools.data.store.EventContentFeatureWriter.write(EventContentFeatureWriter.java:119) at org.geotools.data.InProcessLockingManager$1.write(InProcessLockingManager.java:308) at org.geotools.data.store.ContentFeatureStore.addFeature(ContentFeatureStore.java:295) at org.geotools.data.store.ContentFeatureStore.addFeatures(ContentFeatureStore.java:250) at com.ware4u.geotech.geoprocess.io.FlatGeobufPersistTests.writeData(FlatGeobufPersistTests.java:89) at com.ware4u.geotech.geoprocess.io.FlatGeobufPersistTests.persistFlatGeobuf(FlatGeobufPersistTests.java:80) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:566) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63) at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329) at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293) at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) at org.junit.runners.ParentRunner.run(ParentRunner.java:413) at org.junit.runner.JUnitCore.run(JUnitCore.java:137) at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:69) at com.intellij.rt.junit.IdeaTestRunner$Repeater$1.execute(IdeaTestRunner.java:38) at com.intellij.rt.execution.junit.TestsRepeater.repeat(TestsRepeater.java:11) at com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:35) at com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:232) at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:55)

i want to convert a shapefile to FlatGeobuf format.

if the shapefile has a date type column, the conversion will be failture.

going to the source code and i found the value object is java.util.Date type, None of the code here hits

else if (type == ColumnType.DateTime) { String isoDateTime = ""; if (value instanceof LocalDateTime) { isoDateTime = ((LocalDateTime) value).toString(); } else if (value instanceof LocalDate) { isoDateTime = ((LocalDate) value).toString(); } else if (value instanceof LocalTime) { isoDateTime = ((LocalTime) value).toString(); } else if (value instanceof OffsetDateTime) { isoDateTime = ((OffsetDateTime) value).toString(); } else if (value instanceof OffsetTime) { isoDateTime = ((OffsetTime) value).toString(); } else if (value instanceof java.sql.Date) { isoDateTime = ((java.sql.Date) value).toString(); } else if (value instanceof java.sql.Time) { isoDateTime = ((java.sql.Time) value).toString(); } else if (value instanceof java.sql.Timestamp) { isoDateTime = ((java.sql.Timestamp) value).toString(); } else { throw new RuntimeException( "Cannot handle datetime type " + value.getClass().getName()); } writeString(target, isoDateTime); }

Environment

None

Attachments

1

Activity

Björn Harrtell 
August 12, 2024 at 2:03 PM

AFAIK, yes

Mark Prins 
August 12, 2024 at 1:53 PM

Can this issue be closed?

Björn Harrtell 
May 21, 2024 at 6:49 AM

I’ve broken out the problems found here into separate issues.

Björn Harrtell 
May 20, 2024 at 11:21 AM

That said I’ve made this PR to fix the date time stuff - https://github.com/geotools/geotools/pull/4768 .

Björn Harrtell 
May 20, 2024 at 11:10 AM

looking at the timestamp serialization it doesn’t seem in a good state overall, the intent is to convert to iso datetime strings but I’m not sure the existing support types will do that with a simple toString. So that probably deserves something more than simply adding java.util.Date to the conditionals.

Fixed

Details

Assignee

Reporter

Components

Fix versions

Affects versions

Priority

Created May 10, 2024 at 2:29 PM
Updated August 26, 2024 at 9:16 AM
Resolved August 12, 2024 at 2:33 PM